[Devel] [PATCH rh7 11/39] lib/stackdepot.c: allow the stack trace hash to be zero

Andrey Ryabinin aryabinin at virtuozzo.com
Thu Sep 14 19:51:28 MSK 2017


From: Alexander Potapenko <glider at google.com>

Do not bail out from depot_save_stack() if the stack trace has zero hash.
Initially depot_save_stack() silently dropped stack traces with zero
hashes, however there's actually no point in reserving this zero value.

Reported-by: Joonsoo Kim <iamjoonsoo.kim at lge.com>
Signed-off-by: Alexander Potapenko <glider at google.com>
Acked-by: Andrey Ryabinin <aryabinin at virtuozzo.com>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>

https://jira.sw.ru/browse/PSBM-69081
(cherry picked from commit 33334e25769c6ad69b983379578f42581d99a2f9)
Signed-off-by: Andrey Ryabinin <aryabinin at virtuozzo.com>
---
 lib/stackdepot.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 654c9d87e83a..9e0b0315a724 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -210,10 +210,6 @@ depot_stack_handle_t depot_save_stack(struct stack_trace *trace,
 		goto fast_exit;
 
 	hash = hash_stack(trace->entries, trace->nr_entries);
-	/* Bad luck, we won't store this stack. */
-	if (hash == 0)
-		goto exit;
-
 	bucket = &stack_table[hash & STACK_HASH_MASK];
 
 	/*
-- 
2.13.5



More information about the Devel mailing list