[Devel] [PATCH] sysfs: don't use VE namespace for "dev/char" directory

Kirill Tkhai ktkhai at virtuozzo.com
Wed Sep 13 11:21:20 MSK 2017


On 12.09.2017 19:12, Stanislav Kinsburskiy wrote:
> Looks like we don't have devices, using it. Or lost some patches.
> Anyway, currently it doesn't work. To make this VE namespace work, "namespace"
> callback has to be added to ve_kobj_type. And this callback has to get VE
> structure from kobject somehow. IOW, device has to be allocated per-ve.
> Another issue here is that it's unclear, how to mark generic devices as
> allocated in VE#0 thus making them visible in VE#0.
> Looks like the whole idea was wrong...
> 
> https://jira.sw.ru/browse/PSBM-71811
> 
> Signed-off-by: Stanislav Kinsburskiy <skinsbursky at virtuozzo.com>

Reviewed-by: Kirill Tkhai <ktkhai at virtuozzo.com>

> ---
>  drivers/base/core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 80cf3eb..86540d9 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -1538,7 +1538,7 @@ int __init devices_init(void)
>  	sysfs_dev_block_kobj = kobject_create_and_add("block", dev_kobj);
>  	if (!sysfs_dev_block_kobj)
>  		goto block_kobj_err;
> -	sysfs_dev_char_kobj = kobject_create_and_add_ve("char", dev_kobj);
> +	sysfs_dev_char_kobj = kobject_create_and_add("char", dev_kobj);
>  	if (!sysfs_dev_char_kobj)
>  		goto char_kobj_err;
>  
> 


More information about the Devel mailing list