[Devel] [PATCH rh7 v3] ext4: add generic uevent infrastructure

[Andrey Ryabinin]

On 06/20/2017 07:49 PM, Konstantin Khorenko wrote:
> Kirill, Andrey, what is about Dima's comment?
> 

We've had an offline discussion and Dima is agreed that the GFP_KERNEL is totally ok here.


>> +int ext4_send_uevent(struct super_block *sb, enum ext4_event_type action)
>> +{
>> +    int ret;
>> +    struct kobj_uevent_env *env;
>> +    const u8 *uuid = sb->s_uuid;
>> +    enum kobject_action kaction = KOBJ_CHANGE;
>> +
>> +    env = kzalloc(sizeof(struct kobj_uevent_env), GFP_KERNEL);
> Please change GFP_KERNEL to GFP_NOFS otherwise it may deadlock.
> 
> 
> -- 
> Best regards,
> 
> Konstantin Khorenko,
> Virtuozzo Linux Kernel Team
>