[Devel] [PATCH 3/3] net: do iptables restore in ve0

[Stanislav Kinsburskiy]

24.07.2017 18:46, Andrei Vagin пишет:
> On Mon, Jul 24, 2017 at 06:38:15PM +0300, Cyrill Gorcunov wrote:
>> On Mon, Jul 24, 2017 at 08:34:52AM -0700, Andrei Vagin wrote:
>>>>  
>>>> -static int iptables_tool_restore(char *def_cmd, int fdin)
>>>> +static int __iptables_tool_restore(char *def_cmd, int fdin)
>>>>  {
>>>> +	if (join_ve(root_item->pid->real, false))
>>>
>>> Do you switch here into VE0? Could you add a comment? It is not obvious
>>> that root_item in VE0 at this moment.
>>
>> root_item is NOT in ve0 at this moment, the @false argument points
>> to enter the ve0.
>>
>> int join_ve(pid_t pid, bool veX)
> 
> Does pid have to be 0 in this case?
> 

Maybe interface to this helper should be reworked?