[Devel] [PATCH rh7] net: drop redundant WARN in qdisc_restart()

Konstantin Khorenko khorenko at virtuozzo.com
Mon Dec 18 17:33:51 MSK 2017


+       WARN_ON_ONCE(skb_dst_is_noref(skb));

came to 3.10.0-x on a rebase from 2.6.32-x,
in ms it has been removed by commit:
  0287587884b1 ("net: better IFF_XMIT_DST_RELEASE support")

and the commit presents in current RHEL7 kernel =>

this WARN is a leftover => drop it.

Signed-off-by: Konstantin Khorenko <khorenko at virtuozzo.com>
---
 net/sched/sch_generic.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index 6896dca..ceec603 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -222,7 +222,6 @@ static inline int qdisc_restart(struct Qdisc *q)
 	if (unlikely(!skb))
 		return 0;
 
-	WARN_ON_ONCE(skb_dst_is_noref(skb));
 	root_lock = qdisc_lock(q);
 	dev = qdisc_dev(q);
 	txq = skb_get_tx_queue(dev, skb);
-- 
2.1.4



More information about the Devel mailing list