[Devel] [PATCH] autofs: fix autofs_v5_packet structure for compat mode

Konstantin Khorenko khorenko at virtuozzo.com
Thu Aug 31 13:37:45 MSK 2017


Will you send it to mainstream as well?

--
Best regards,

Konstantin Khorenko,
Virtuozzo Linux Kernel Team

On 08/31/2017 01:11 PM, Stanislav Kinsburskiy wrote:
> Due to integer variables alignment size of struct autofs_v5_packet in 300
> bytes in 32-bit architectures (instead of 304 bytes in 64-bits architectures).
>
> This may lead to memory corruption (64 bits kernel always send 304 bytes,
> while 32-bit userspace application expects for 300).
>
> https://jira.sw.ru/browse/PSBM-71078
>
> Signed-off-by: Stanislav Kinsburskiy <skinsbursky at virtuozzo.com>
> ---
>  include/uapi/linux/auto_fs4.h |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/uapi/linux/auto_fs4.h b/include/uapi/linux/auto_fs4.h
> index e02982f..8729a47 100644
> --- a/include/uapi/linux/auto_fs4.h
> +++ b/include/uapi/linux/auto_fs4.h
> @@ -137,6 +137,8 @@ struct autofs_v5_packet {
>  	__u32 pid;
>  	__u32 tgid;
>  	__u32 len;
> +	__u32 blob;		/* This is needed to align structure up to 8
> +				   bytes for ALL archs including 32-bit */
>  	char name[NAME_MAX+1];
>  };
>
>
> .
>


More information about the Devel mailing list