[Devel] [PATCH rh7] fs/dax: remove comment leftover

Andrey Ryabinin aryabinin at virtuozzo.com
Tue Aug 29 11:54:35 MSK 2017


mem_cgroup_uncharge_page() call in dax_mapping_entry() not needed.
Uncharging now happens in __page_cache_release()

Should be merged in b3c711a7287f ("ms/mm: memcontrol: rewrite uncharge API")

https://jira.sw.ru/browse/PSBM-70742
Signed-off-by: Andrey Ryabinin <aryabinin at virtuozzo.com>
---
 fs/dax.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/dax.c b/fs/dax.c
index 1a7d6a5e3e07..2e0c8ba24f30 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -643,7 +643,6 @@ static void *dax_insert_mapping_entry(struct address_space *mapping,
 		       RADIX_DAX_ENTRY_LOCK);
 	if (hole_fill) {
 		__delete_from_page_cache(entry, NULL);
-// FIXME		mem_cgroup_uncharge_page(entry);
 		/* Drop pagecache reference */
 		page_cache_release(entry);
 		error = radix_tree_insert(page_tree, index, new_entry);
-- 
2.13.5



More information about the Devel mailing list