[Devel] [PATCH 0/2] fuse: fix signals handling while processing request

[Maxim Patlasov]

Stas,


The series look fine, so:

Acked-by: Maxim Patlasov <mpatlasov at virtuozzo.com>


But, please, refine the description of the second patch. It must explain 
clearly why the patch fixes the problem:

block_sigs() blocks ordinary non-fatal signals as expected, but 
surprisingly SIGTRAP is special: it does not matter whether it comes 
before or after block_sigs(), the latter does not affect SIGTRAP at all! 
And in contrast, wait_event_killable() is immune to it -- only fatal sig 
can wake it up.

Thanks,
Maxim

On 10/13/2016 03:03 AM, Stanislav Kinsburskiy wrote:
> This patch fixes wrong SIGBUS result in page fault handler for fuse file, when
> process received a signal.
>
> https://jira.sw.ru/browse/PSBM-53581
>
> ---
>
> Stanislav Kinsburskiy (2):
>        new helper: wait_event_killable_exclusive()
>        fuse: handle only fatal signals while waiting request answer
>
>
>   fs/fuse/dev.c        |   42 ++++++++++++++++--------------------------
>   include/linux/wait.h |   26 ++++++++++++++++++++++++++
>   2 files changed, 42 insertions(+), 26 deletions(-)
>
> --