[Devel] [PATCH RHEL7 COMMIT] ms/net: ip, raw_diag -- Use jump for exiting from nested loop
Konstantin Khorenko
khorenko at virtuozzo.com
Wed Nov 23 07:28:29 PST 2016
The commit is pushed to "branch-rh7-3.10.0-327.36.1.vz7.20.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-327.36.1.vz7.20.1
------>
commit b2449114b92fb81c270e5649957f0db7e2fc38dd
Author: Cyrill Gorcunov <gorcunov at virtuozzo.com>
Date: Wed Nov 23 19:28:29 2016 +0400
ms/net: ip, raw_diag -- Use jump for exiting from nested loop
Patchset description:
These are backports from net-next tree. The patches are needed
to support c/r of raw sockets (criu part is to be implemented).
https://jira.sw.ru/browse/PSBM-51614
===
This patch description:
net-next: 9999370faed945be2913cd34aa24e84317a0ceda
I managed to miss that sk_for_each is called under "for"
cycle so need to use goto here to return matching socket.
CC: David S. Miller <davem at davemloft.net>
CC: Eric Dumazet <eric.dumazet at gmail.com>
CC: David Ahern <dsa at cumulusnetworks.com>
CC: Andrey Vagin <avagin at openvz.org>
CC: Stephen Hemminger <stephen at networkplumber.org>
Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
Acked-by: David Ahern <dsa at cumulusnetworks.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
Signed-off-by: Cyrill Gorcunov <gorcunov at virtuozzo.com>
---
net/ipv4/raw_diag.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/raw_diag.c b/net/ipv4/raw_diag.c
index 1c31706..05ea95d 100644
--- a/net/ipv4/raw_diag.c
+++ b/net/ipv4/raw_diag.c
@@ -79,10 +79,11 @@ static struct sock *raw_sock_get(struct net *net, const struct inet_diag_req_v2
* hashinfo->lock here.
*/
sock_hold(sk);
- break;
+ goto out_unlock;
}
}
}
+out_unlock:
read_unlock(&hashinfo->lock);
return sk ? sk : ERR_PTR(-ENOENT);
More information about the Devel
mailing list