[Devel] [PATCH RHEL7] kmod/whitelist: rename {,fs-}binfmt_misc

[Dmitry Safonov]

On 05/23/2016 06:52 PM, Kirill Tkhai wrote:
>
>
> On 23.05.2016 18:40, Dmitry Safonov wrote:
>> On 05/23/2016 06:29 PM, Kirill Tkhai wrote:
>>> On 23.05.2016 18:25, Dmitry Safonov wrote:
>>>> On 05/23/2016 06:25 PM, Kirill Tkhai wrote:
>>>>>
>>>>> Where it is loaded from? In search_binary_handler() I see "binfmt_misc" without prefix.
>>>>
>>>> Yeah.
>>>>
>>>> get_fs_type:
>>>> if (!fs && (request_module("fs-%.*s", len, name) == 0))
>>>>
>>>> Adds 'fs-' prefix on mount.
>>>
>>> Shouldn't we keep them both?
>>>
>>
>> I'm doubting: the initial issue was about criu migration failure,
>> which tries to mount binfmt fs on restore.
>> So, that's got fixed nicely.
>
> Ok, good
>
>> I'm not sure, what for keeping binfmt_misc there?
>
> It gives assymmetry, so it's just the reason to check it again.
> I don't think search_binary_handler() will be need on restore stage.
>
> Reviewed-by: Kirill Tkhai <ktkhai at virtuozzo.com>

Thanks!