[Devel] [PATCH 04/10] lift the "already marked killed" case into shrink_dentry_list()

[Vladimir Davydov]

From: Al Viro <viro at zeniv.linux.org.uk>

It can happen only when dentry_kill() is called with unlock_on_failure
equal to 0 - other callers had dentry pinned until the moment they've
got ->d_lock and DCACHE_DENTRY_KILLED is set only after lockref_mark_dead().

IOW, only one of three call sites of dentry_kill() might end up reaching
that code.  Just move it there.

Signed-off-by: Al Viro <viro at zeniv.linux.org.uk>
(cherry picked from commit 64fd72e0a44bdd62c5ca277cb24d0d02b2d8e9dc)
Signed-off-by: Vladimir Davydov <vdavydov at virtuozzo.com>

Conflicts:
	fs/dcache.c
---
 fs/dcache.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/fs/dcache.c b/fs/dcache.c
index c584d23a194a..37420f461ca2 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -495,14 +495,6 @@ dentry_kill(struct dentry *dentry, int unlock_on_failure)
 	struct inode *inode;
 	struct dentry *parent;
 
-	if (unlikely(dentry->d_flags & DCACHE_DENTRY_KILLED)) {
-		bool can_free = dentry->d_flags & DCACHE_MAY_FREE;
-		spin_unlock(&dentry->d_lock);
-		if (likely(can_free))
-			dentry_free(dentry);
-		return NULL;
-	}
-
 	inode = dentry->d_inode;
 	if (inode && !spin_trylock(&inode->i_lock)) {
 relock:
@@ -845,6 +837,15 @@ static void shrink_dentry_list(struct list_head *list)
 			continue;
 		}
 
+
+		if (unlikely(dentry->d_flags & DCACHE_DENTRY_KILLED)) {
+			bool can_free = dentry->d_flags & DCACHE_MAY_FREE;
+			spin_unlock(&dentry->d_lock);
+			if (can_free)
+				dentry_free(dentry);
+			continue;
+		}
+
 		parent = dentry_kill(dentry, 0);
 		/*
 		 * If dentry_kill returns NULL, we have nothing more to do.
-- 
2.1.4