[Devel] [PATCH rh7] tty: vtty -- Drop TTY_PINNED_BY_OTHER bit

Cyrill Gorcunov gorcunov at virtuozzo.com
Thu Mar 24 07:58:27 PDT 2016


On Thu, Mar 24, 2016 at 05:41:43PM +0300, Vladimir Davydov wrote:
> On Fri, Mar 18, 2016 at 09:45:05PM +0300, Cyrill Gorcunov wrote:
> > @@ -2043,8 +2044,7 @@ static ssize_t n_tty_write(struct tty_st
> >  		}
> >  #ifdef CONFIG_VE
> >  		if (tty_hung_up_p(file) ||
> > -		    (tty->link && !tty->link->count &&
> > -		     !(test_bit(TTY_PINNED_BY_OTHER, &tty->link->flags)))) {
> > +		    (tty->link && !tty->link->count && !vtty_is_master(tty->link))) {
> >  #else
> 
> I'd got rid of this ifdef while we are here.

Please no. It's easier to catch merge conflicts having CONFIG_VE.

> > +bool vtty_is_master(struct tty_struct *tty)
> > +{
> > +	return tty->driver == vttym_driver;
> > +}
> > +EXPORT_SYMBOL(vtty_is_master);
> > +
> 
> No point to export it. Anyway,

Yeah. Kostya, could you simply drop it when merging.

> 
> Reviewed-by: Vladimir Davydov <vdavydov at virtuozzo.com>

	Cyrill


More information about the Devel mailing list