[Devel] [PATCH RHEL7 COMMIT] ploop: deadcode cleanup in dio_submit()

Konstantin Khorenko khorenko at virtuozzo.com
Fri Jun 24 03:25:04 PDT 2016


The commit is pushed to "branch-rh7-3.10.0-327.18.2.vz7.14.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-327.18.2.vz7.14.19
------>
commit 55e7ee0745a5ad542e7a4e25d65ea0967440c078
Author: Dmitry Monakhov <dmonakhov at openvz.org>
Date:   Fri Jun 24 14:25:04 2016 +0400

    ploop: deadcode cleanup in dio_submit()
    
    (rw & REQ_FUA) branch is impossible because REQ_FUA was cleared line above.
    Logic was moved to ploop_req_delay_fua_possible() long time ago.
    
    Signed-off-by: Dmitry Monakhov <dmonakhov at openvz.org>
    Acked-by: Maxim Patlasov <mpatlasov at virtuozzo.com>
---
 drivers/block/ploop/io_direct.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/block/ploop/io_direct.c b/drivers/block/ploop/io_direct.c
index e92fb64..50cdbf7 100644
--- a/drivers/block/ploop/io_direct.c
+++ b/drivers/block/ploop/io_direct.c
@@ -114,15 +114,6 @@ dio_submit(struct ploop_io *io, struct ploop_request * preq,
 	rw &= ~(REQ_FLUSH | REQ_FUA);
 
 
-	/* In case of eng_state != COMPLETE, we'll do FUA in
-	 * ploop_index_update(). Otherwise, we should mark
-	 * last bio as FUA here. */
-	if (rw & REQ_FUA) {
-		rw &= ~REQ_FUA;
-		if (preq->eng_state == PLOOP_E_COMPLETE)
-			postfua = 1;
-	}
-
 	bio_list_init(&bl);
 
 	if (iblk == PLOOP_ZERO_INDEX)


More information about the Devel mailing list