[Devel] [PATCH] ve: mark DEF_PERMS feature deprecated

Kirill Tkhai ktkhai at virtuozzo.com
Tue Jun 21 05:41:19 PDT 2016


On 21.06.2016 14:23, Evgenii Shatokhin wrote:
> "def_perms" is not mentioned in the man pages for prlctl and vzctl.
> 
> VE_FEATURE_DEF_PERMS is only used in the kernel code as a part of
> VE_FEATURES_DEF ("ve->features = VE_FEATURES_DEF;" in ve_create()).
> No code checks if the bit for this feature is set in ve->features.
> 
> Let us mark this feature deprecated, similar to SYSFS and IPGRE
> features.
> 
> https://jira.sw.ru/browse/PSBM-40280
> 
> Signed-off-by: Evgenii Shatokhin <eshatokhin at virtuozzo.com>

Reviewed-by: Kirill Tkhai <ktkhai at virtuozzo.com>

> ---
>  include/uapi/linux/vzcalluser.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/vzcalluser.h b/include/uapi/linux/vzcalluser.h
> index 2b340cf..bc55bb3 100644
> --- a/include/uapi/linux/vzcalluser.h
> +++ b/include/uapi/linux/vzcalluser.h
> @@ -115,7 +115,7 @@ struct env_create_param3 {
>  
>  #define VE_FEATURE_SYSFS	(1ULL << 0)	/* deprecated */
>  #define VE_FEATURE_NFS		(1ULL << 1)
> -#define VE_FEATURE_DEF_PERMS	(1ULL << 2)
> +#define VE_FEATURE_DEF_PERMS	(1ULL << 2)	/* deprecated */
>  #define VE_FEATURE_SIT          (1ULL << 3)
>  #define VE_FEATURE_IPIP         (1ULL << 4)
>  #define VE_FEATURE_PPP		(1ULL << 5)
> 


More information about the Devel mailing list