[Devel] [PATCH 2/3] ploop: deadcode cleanup

Dmitry Monakhov dmonakhov at openvz.org
Mon Jun 20 11:58:38 PDT 2016


(rw & REQ_FUA) branch is impossible because REQ_FUA was cleared line above.
Logic was moved to ploop_req_delay_fua_possible() long time ago.

Signed-off-by: Dmitry Monakhov <dmonakhov at openvz.org>
---
 drivers/block/ploop/io_direct.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/block/ploop/io_direct.c b/drivers/block/ploop/io_direct.c
index 58d7580..a6d83fe 100644
--- a/drivers/block/ploop/io_direct.c
+++ b/drivers/block/ploop/io_direct.c
@@ -108,15 +108,6 @@ dio_submit(struct ploop_io *io, struct ploop_request * preq,
 	rw &= ~(REQ_FLUSH | REQ_FUA);
 
 
-	/* In case of eng_state != COMPLETE, we'll do FUA in
-	 * ploop_index_update(). Otherwise, we should mark
-	 * last bio as FUA here. */
-	if (rw & REQ_FUA) {
-		rw &= ~REQ_FUA;
-		if (preq->eng_state == PLOOP_E_COMPLETE)
-			postfua = 1;
-	}
-
 	bio_list_init(&bl);
 
 	if (iblk == PLOOP_ZERO_INDEX)
-- 
1.8.3.1



More information about the Devel mailing list