[Devel] [PATCH RHEL7 COMMIT] ms/ixgbe: on recv increment rx.ring->stats.yields

Konstantin Khorenko khorenko at virtuozzo.com
Thu Jan 21 08:22:27 PST 2016


The commit is pushed to "branch-rh7-3.10.0-229.7.2.vz7.9.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-229.7.2.vz7.9.24
------>
commit d5f913099a79540bccce9fb4e6eb28e8b57f5b1a
Author: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>
Date:   Thu Jan 21 20:22:27 2016 +0400

    ms/ixgbe: on recv increment rx.ring->stats.yields
    
    It seem to be non intentionaly changed to tx in
    commit adc810900a70 ("ixgbe: Refactor busy poll socket code to address
    multiple issues")
    
    Lock is taken from ixgbe_low_latency_recv, and there under this
    lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
    tx counter.
    
    Yield stats can be shown through ethtool:
    ethtool -S enp129s0 | grep yield
    
    v2: follow commit citing style
    
    Signed-off-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
index 00da363..e4532e8 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
@@ -425,7 +425,7 @@ static inline bool ixgbe_qv_lock_poll(struct ixgbe_q_vector *q_vector)
 				IXGBE_QV_STATE_POLL);
 #ifdef LL_EXTENDED_STATS
 	if (rc != IXGBE_QV_STATE_IDLE)
-		q_vector->tx.ring->stats.yields++;
+		q_vector->rx.ring->stats.yields++;
 #endif
 	return rc == IXGBE_QV_STATE_IDLE;
 }


More information about the Devel mailing list