[Devel] [PATCH rh7 v3 3/3] ve/fs/sync: don't skip dirty metatdata on filtered sync

[Konstantin Khorenko]

On 02/04/2016 12:32 PM, Vladimir Davydov wrote:
> On Wed, Feb 03, 2016 at 07:46:12PM +0300, Andrey Ryabinin wrote:
>> Port of diff-ubc-dont-skip-dirty-metadata-on-filtered-sync patch
>> from PCS6.
>>
>> Don't skip dirty metadata during per container sync[fs].
>>
>> https://jira.sw.ru/browse/PSBM-39583
>>
>> Signed-off-by: Andrey Ryabinin <aryabinin at virtuozzo.com>
>
> The patch looks correct to me.
>
> Reviewed-by: Vladimir Davydov <vdavydov at virtuozzo.com>
>
> However, I've no idea why it was added to PCS6, neither do I know if we
> still need it - unfortunately the original comment is not very helpful.
> Konstantin?

date: 2012/01/11 19:59:46; author: xemul; state: Exp;
Author: Konstantin Khlebnikov
Email: khlebnikov at openvz.org
Subject: ubc: disable filtered sync for too dirty inodes
Date: Tue, 10 Jan 2012 17:45:25 +0400

Filter only inodes with clean meta-data.

We cannot filter writes in this case. Actually we only move writes to
the journal thread, and it submit them in not very effective way.

Found-by: Alexey Kuznetsov <kuznet at parallels.com>

Signed-off-by: Konstantin Khlebnikov <khlebnikov at openvz.org>
===================================================================

Looks like it was important for vzfs when all CTs shared single journal,
so it is more efficient to help writing journal data in the current context comparing to moving all the stuff to single kjournald.

In Virtuozzo 7 we don't have vzfs, ploop-based Containers have separate journals =>
i'm dropping this patch.

--
Best regards,

Konstantin Khorenko,
Virtuozzo Linux Kernel Team