[Devel] [PATCH vz7] fuse: no mtime flush on fdatasync

Dmitry Monakhov dmonakhov at openvz.org
Fri Dec 2 06:09:40 PST 2016


Maxim Patlasov <mpatlasov at virtuozzo.com> writes:

> fuse_fsync_common() may skip fuse_flush_mtime() if datasync=1 because
> mtime is pure metadata and the content of file doesn't depend on it.
>
> https://jira.sw.ru/browse/PSBM-55919
>
> Signed-off-by: Maxim Patlasov <mpatlasov at virtuozzo.com>
ACK.
> ---
>  fs/fuse/file.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 559dfd9..e5c4778 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -684,8 +684,8 @@ int fuse_fsync_common(struct file *file, loff_t start, loff_t end,
>  	if (err)
>  		goto out;
>  
> -	if (test_bit(FUSE_I_MTIME_UPDATED,
> -		     &get_fuse_inode(inode)->state)) {
> +	if (!datasync && test_bit(FUSE_I_MTIME_UPDATED,
> +				  &get_fuse_inode(inode)->state)) {
>  		err = fuse_flush_mtime(file, false);
>  		if (err)
>  			goto out;


More information about the Devel mailing list