[Devel] [PATCH rh7] ve: rework veid handling
Vladimir Davydov
vdavydov at parallels.com
Thu Sep 24 03:23:47 PDT 2015
On Thu, Sep 24, 2015 at 12:45:46PM +0300, Kirill Tkhai wrote:
...
> > @@ -438,6 +445,10 @@ int ve_start_container(struct ve_struct *ve)
> > ve_grab_context(ve);
> > ve_list_add(ve);
> >
> > + err = ve_alloc_id(ve);
> > + if (err)
> > + goto err_id;
>
> I'm confused in a fact we add a ve to &ve_list_head, before we know
> the ve's id is unique. for_each_ve() users are able to pick it at the moment.
Right, will fix.
>
> Furthermore, it looks confusing, we add a ve to the list, before it's completely
> initialized.
I don't want to change the original behavior in this patch. May be I'll
do it separately.
Thanks.
More information about the Devel
mailing list