[Devel] [PATCH vz7 v2 1/3] venet: fix false positive return code in case of error in venet_init()

Stanislav Kinsburskiy skinsbursky at odin.com
Tue Sep 22 06:41:36 PDT 2015


From: Stanislav Kinsburskiy <skinsbursky at parallels.com>

It's set to 0 few lines above.

Signed-off-by: Stanislav Kinsburskiy <skinsbursky at parallels.com>
---
 drivers/net/venetdev.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/venetdev.c b/drivers/net/venetdev.c
index d16ac3d..50b3c91 100644
--- a/drivers/net/venetdev.c
+++ b/drivers/net/venetdev.c
@@ -1230,8 +1230,10 @@ __init int venet_init(void)
 
 	de = proc_create("veip", S_IFREG | S_IRUSR, proc_vz_dir,
 			&proc_veip_operations);
-	if (!de)
+	if (!de) {
+		err = -EINVAL;
 		goto err_proc;
+	}
 
 	err = cgroup_add_cftypes(&ve_subsys, venet_cftypes);
 	if (err)




More information about the Devel mailing list