[Devel] [PATCH rh7 2/3] ve: Wait till ve's attaching work finished

[Vladimir Davydov]

On Wed, Oct 28, 2015 at 12:54:10PM +0300, Kirill Tkhai wrote:
...
> >> +static void ve_wait_work(struct callback_head *head)
> >> +{
> >> +	atomic_t *nr = &current->task_ve_nr_works;
> >> +
> >> +	while (atomic_read(nr))
> >> +		schedule_timeout(1);
> > 
> > Let's not introduce such temporary solutions. They look misleading and
> > don't ease review. I think it'd be OK to merge patches 2 and 3.
> 
> It's not a new interface, it's just a stub. Could you please explain,
> how it mislead a reviewer?

You don't mention it's a stub anywhere. People usually don't start
reviewing a patch set from the end, you know. I do sometimes though :-)

> 
> The thing is I splited patches 2 and 3 after I saw the big one is difficult
> to review.

Try simplifying patch 3 then?

>  
> >> +
> >> +	init_task_work(&current->task_ve_work, NULL);
> >>  }
> >>  
> >>  static int ve_can_attach(struct cgroup *cg, struct cgroup_taskset *tset)
>