[Devel] [PATCH RH7 1/9] Port: diff-fence-watchdog-introduce-fencing-watchdog-for-HA-cluster-3

[Andrew Vagin]

On Tue, Nov 17, 2015 at 10:46:02AM +0300, Pavel Tikhomirov wrote:
> >diff --git a/arch/x86/include/asm/vvar.h b/arch/x86/include/asm/vvar.h
> >index de656ac..1ae9a5c 100644
> >--- a/arch/x86/include/asm/vvar.h
> >+++ b/arch/x86/include/asm/vvar.h
> >@@ -45,6 +45,7 @@
> >
> >  DECLARE_VVAR(0, volatile unsigned long, jiffies)
> >  DECLARE_VVAR(16, int, vgetcpu_mode)
> >+DECLARE_VVAR(64, volatile unsigned long, fence_wdog_jiffies64)
> >  DECLARE_VVAR(128, struct vsyscall_gtod_data, vsyscall_gtod_data)
> >
> >  #undef DECLARE_VVAR
> 
> I couldn't find reason why here are such big offsets between variables in
> commit messages, so I asked Andy Lutomirski, who introduced vvar.h, and he
> said that there is no good reason now, and he put variables like this to
> keep them cacheline-aligned and to avoid worrying about space - "there's 4k
> of space, so keeping everything compact serves no purpose."

Ok, thanks.
> 
> -- 
> Best regards, Tikhomirov Pavel
> Software Developer, Odin.