[Devel] [PATCH rh7 02/11] ub: zap show_ub_mem

[Vladimir Davydov]

On Fri, May 22, 2015 at 10:07:13PM +0300, Konstantin Khorenko wrote:
> On 05/20/2015 12:00 PM, Vladimir Davydov wrote:
> > It is called by the showmem sysctl. Hell knows why it was added and who
> > would ever used it.
> It's not about sysctl, but about sysrq

typo, sorry

> and we used it heavily until we start getting crash dumps from most of nodes.
> => you forgot to get rid of other parts of that as well:
> 
> static struct sysrq_key_op sysrq_unrt_op = {
>         .handler        = sysrq_handle_unrt,
>         .help_msg       = "nice-all-RT-tasks(n)",
>         .action_msg     = "Nice All RT Tasks",
>         .enable_mask    = SYSRQ_ENABLE_RTNICE,
> };
> ...
> static struct sysrq_key_op *sysrq_key_table[36] = {
> ...
>         &sysrq_showmem_op,              /* m */
> 
> Volodya, please, make the patch complete.

It *IS* complete. I only drop show_ub_mem, which was called from
showmem sysrq to show per-UB memory stats. The sysrq itself is still
there and I am not going to remove it.