[Devel] [patch rh7 2/2] ve: ioctls -- call put_ve in real_env_create

[Vladimir Davydov]

On Tue, May 05, 2015 at 08:02:08PM +0300, Cyrill Gorcunov wrote:
> Our cgroups based VE's aleady carrying own reference
> so here we should call for put_ve, otherwise it gonna
> be hangin around.
> 
> p.s. I didn't hit any problem with it yet because we're
> operating via cgroups interface now but if I'm not missing
> something obvious we're doing redunt get_ve here so call
> put one for balance. Found when been hunting another bug.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at odin.com>
> CC: Vladimir Davydov <vdavydov at odin.com>
> CC: Konstantin Khorenko <khorenko at odin.com>
> CC: Pavel Emelyanov <xemul at odin.com>
> CC: Andrey Vagin <avagin at odin.com>
> ---
>  kernel/ve/vecalls.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: linux-pcs7.git/kernel/ve/vecalls.c
> ===================================================================
> --- linux-pcs7.git.orig/kernel/ve/vecalls.c
> +++ linux-pcs7.git/kernel/ve/vecalls.c
> @@ -588,7 +588,6 @@ int real_env_create(envid_t veid, unsign
>  
>  	if (flags & VE_CREATE) {
>  		status = do_env_create(veid, flags, class_id, data, datalen);
> -		goto out;

AFAICS if we got here, ve must be NULL, so this patch changes nothing.

>  	} else if (flags & VE_ENTER)
>  		status = do_env_enter(ve, flags);
>  
>