[Devel] [PATCH rh7 02/11] ub: zap show_ub_mem

Vasily Averin vvs at virtuozzo.com
Fri May 22 23:10:21 PDT 2015



On 22.05.2015 22:07, Konstantin Khorenko wrote:
> On 05/20/2015 12:00 PM, Vladimir Davydov wrote:
>> It is called by the showmem sysctl. Hell knows why it was added and who
>> would ever used it.
> It's not about sysctl, but about sysrq and we used it heavily until we start getting crash dumps from most of nodes.
> => you forgot to get rid of other parts of that as well:
> 
> static struct sysrq_key_op sysrq_unrt_op = {
>         .handler        = sysrq_handle_unrt,
>         .help_msg       = "nice-all-RT-tasks(n)",
>         .action_msg     = "Nice All RT Tasks",
>         .enable_mask    = SYSRQ_ENABLE_RTNICE,
> };
> ...
> static struct sysrq_key_op *sysrq_key_table[36] = {
> ...
>         &sysrq_showmem_op,              /* m */
> 
> Volodya, please, make the patch complete.
> 
> Vasya, do we still consider Alt+SysRQ+m useful?
> i tend to agree to drop it for now.

I did not get, do you want to drop sysrq key for meminfo at all?
Do you want to re-use 'm' key in sysrq?

I personally did not used M for last years,
But I think we need to keep RHEL implemtation of this handler.  



More information about the Devel mailing list