[Devel] [PATCH RHEL7 COMMIT] ve/kernel/taint: Port diff-taint-message-enhanced-with-dump

Konstantin Khorenko khorenko at virtuozzo.com
Wed Jun 24 05:32:07 PDT 2015


The commit is pushed to "branch-rh7-3.10.0-123.1.2-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-123.1.2.vz7.5.17
------>
commit fb61d4710f15ff3fd4eb9ed9e233cca24a3f2f61
Author: Vladimir Davydov <vdavydov at parallels.com>
Date:   Wed Jun 24 16:32:06 2015 +0400

    ve/kernel/taint: Port diff-taint-message-enhanced-with-dump
    
    This patch adds an additional message on tainting kernel
    (to easily find the place in huge logs) and a dump stack
    because sometimes we taint kernel with the same flag (TAINT_CRAP)
    in several places.
    
    Signed-off-by: Konstantin Khorenko <khorenko at openvz.org>
    
    =============================================================================
    
    Author: Konstantin Khorenko
    Email: khorenko at parallels.com
    Subject: taint: do not print calltraces on proprietary modules
    Date: Wed, 02 Apr 2014 20:08:33 +0400
    
    This can confuse admins => do not print additional calltraces
    on proprietary modules load.
    
    https://jira.sw.ru/browse/PSBM-25867
    
    Signed-off-by: Konstantin Khorenko <khorenko at parallels.com>
    
    =============================================================================
    
    Related to https://jira.sw.ru/browse/PSBM-33650
    
    Signed-off-by: Vladimir Davydov <vdavydov at parallels.com>
---
 kernel/panic.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kernel/panic.c b/kernel/panic.c
index 58520a5..3dd4320 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -289,6 +289,11 @@ void add_taint(unsigned flag, enum lockdep_ok lockdep_ok)
 		printk(KERN_WARNING
 		       "Disabling lock debugging due to kernel taint\n");
 
+	/* Do not confuse people with calltraces on proprietary modules */
+	if (flag != TAINT_PROPRIETARY_MODULE) {
+		printk(KERN_WARNING "Tainting kernel with flag 0x%x\n", flag);
+		dump_stack();
+	}
 	set_bit(flag, &tainted_mask);
 }
 EXPORT_SYMBOL(add_taint);



More information about the Devel mailing list