[Devel] [PATCH rh7] ve: introduce ve.veid for setting id from userspace

Cyrill Gorcunov gorcunov at virtuozzo.com
Sat Jun 20 10:18:42 PDT 2015


On Sat, Jun 20, 2015 at 07:27:30PM +0300, Vladimir Davydov wrote:
...
> +static int ve_id_write(struct cgroup *cg, struct cftype *cft, u64 value)
> +{
> +	struct ve_struct *ve = cgroup_ve(cg);
> +	int veid;
> +	int err = 0;
> +
> +	if (value <= 0 || value > INT_MAX)
> +		return -EINVAL;

A small nit -- @value is unsigned no need for <= test.
Other than that, looks great, thank you!

Acked-by: Cyrill Gorcunov <gorcunov at openvz.org>



More information about the Devel mailing list