[Devel] [PATCH rh7] venetstat: Add ioctl interface via VE cgroup

Vladimir Davydov vdavydov at parallels.com
Fri Jun 19 01:23:34 PDT 2015


On Fri, Jun 19, 2015 at 11:10:14AM +0300, Cyrill Gorcunov wrote:
> On Fri, Jun 19, 2015 at 10:55:29AM +0300, Vladimir Davydov wrote:
> > > "venet_acct_ioctl" which would emulate old ioctls.
> > > 
> > > The write action into this file should pass
> > > struct vz_tc_cg_req as an argument so that
> > > it get unpacked into argument and command
> > > for ioctl call and execute it.
> > 
> > IMHO this looks like trading bad for worse. Why can't we just use legacy
> > ioctls for a start?
> 
> Sigh. It seems I misunderstood the problem itself :/ I thought
> we're having troubles in calling ioctl but the problem is rathe
> in ioctl internals code, where veid should be passed inside arguments
> but we need to get rid of them. Drop this patch please, I'll rework.

I'd prefer to pass legacy_veid to these ioctls instead of introducing a
new API just to zap it in the next major release...



More information about the Devel mailing list