[Devel] [PATCH rh7 0/7] ub: resurrect blkio prio/stats

[Dmitry Monakhov]

Konstantin Khorenko <khorenko at virtuozzo.com> writes:

> Dima, please review the patchset.
>
> --
> Best regards,
>
> Konstantin Khorenko,
> Virtuozzo Linux Kernel Team
>
> On 06/09/2015 05:06 PM, Vladimir Davydov wrote:
>> https://jira.sw.ru/browse/PSBM-34007
>> 
>> Vladimir Davydov (7):
>>   ioprio: move IOPRIO_WHO_UBC handling out of rcu section
>>   ub: zap ub_{init,fini}_ioprio
>>   ub: export ub_get_{mem,blkio}_css
>>   ub: ressurrect ioprio_set IOPRIO_WHO_UBC
>>   ub: ressurrect iostat and ioprio reporting
>>   ub: account writeback io
>>   ub: do not include block/blk-cgroup.h from io_prio.c
ACK for 1-7'th patches. The only minor question for 'ub: account writeback io'
please see comments below.
>+static int
>+__writeback_single_inode(struct inode *inode, struct writeback_control  *wbc)
>+{
>+       struct user_beancounter *ub = inode->i_mapping->dirtied_ub;
>+       int ret;
>+
>+       if (likely(get_exec_ub() == ub || !ub))
         if (ub == NULL) than we will use current content which deviate
         statistics a bit. Can we do  set_exec_ub(NULL) here?
>+          return __do_writeback_single_inode(inode, wbc);
>+
>+       ub = get_beancounter_rcu(ub) ? set_exec_ub(ub) : NULL;
>+       ret = __do_writeback_single_inode(inode, wbc);
>+       if (ub)
>+          put_beancounter(set_exec_ub(ub));
>+
>+       return ret;

>> 
>>  block/cfq-iosched.c      |  72 +++++++++++++++++++++++++++++++
>>  fs/fs-writeback.c        |  19 +++++++-
>>  fs/ioprio.c              |  14 +++---
>>  include/bc/beancounter.h |  18 ++++++--
>>  kernel/bc/Makefile       |   2 -
>>  kernel/bc/beancounter.c  |  15 +------
>>  kernel/bc/io_prio.c      | 110 ++++++++++++-----------------------------------
>>  7 files changed, 140 insertions(+), 110 deletions(-)
>> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 472 bytes
Desc: not available
URL: <http://lists.openvz.org/pipermail/devel/attachments/20150610/122a37fe/attachment-0001.sig>