[Devel] [PATCH rh7] ve/pty: create ptmx device per ve namespace

Cyrill Gorcunov gorcunov at virtuozzo.com
Wed Jul 29 07:20:14 PDT 2015


On Wed, Jul 29, 2015 at 05:10:54PM +0300, Vladimir Davydov wrote:
> After Unix98 PTY driver "virtualization" was reverted, we have to
> manually set sysfs permissions for ptmx. This, however, is currently
> impossible, because tty_class is still virtualized, which makes
> ve.sysfs_permissions ignore it (see sysfs_perms_set).
> 
> This patch is a quick-fix which simply creates/destroys ptmx device in
> ve namespace on container start/stop. It must be dropped when commit
> 6022450d12653 ("ve/tty: make tty_class VE-namespace aware") is reverted.
> 
> Signed-off-by: Vladimir Davydov <vdavydov at parallels.com>

Looks good. Dropping tty_class will be possible once I convert my
virtual terminals module (in process, testing now, hopefully to
finish today). IOW, I'll grab this patch as well into my queue
to test all things together.



More information about the Devel mailing list