[Devel] [PATCH rh7 v2 1/2] sched: Fix schedule_tail() to disable preemption

Vladimir Davydov vdavydov at parallels.com
Thu Aug 20 09:15:17 PDT 2015


On Thu, Aug 20, 2015 at 07:09:23PM +0300, Kirill Tkhai wrote:
> Porting commit 1a43a14a5bd9c32dbd7af35e35a5afa703944bcb by Oleg Nesterov:
> 
> finish_task_switch() enables preemption, so post_schedule(rq) can be
> called on the wrong (and even dead) CPU. Afaics, nothing really bad
> can happen, but in this case we can wrongly clear rq->post_schedule
> on that CPU. And this simply looks wrong in any case.
> 
> Signed-off-by: Oleg Nesterov <oleg at redhat.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz at infradead.org>
> Cc: Steven Rostedt <rostedt at goodmis.org>
> Cc: Kirill Tkhai <tkhai at yandex.ru>
> Cc: Linus Torvalds <torvalds at linux-foundation.org>
> Link: http://lkml.kernel.org/r/20141008193644.GA32055@redhat.com
> Signed-off-by: Ingo Molnar <mingo at kernel.org>
> Signed-off-by: Kirill Tkhai <ktkhai at odin.com>

I've already reviewed this one, and it didn't change in v2. You could've
added my reviewed-by. Anyway,

Reviewed-by: Vladimir Davydov <vdavydov at parallels.com>



More information about the Devel mailing list