[Devel] [PATCH] scripts/prestart.sh: don't execute fixup_udev in background

Kir Kolyshkin kir at openvz.org
Wed Jan 22 15:04:23 PST 2014


On 01/22/2014 02:39 AM, Andrey Vagin wrote:
> This script must be started before the init will be executed,
> so it must not be executed in background.

It was executed in background because the whole point of fixup_udev()
was to wait till container starts and then do a few umounts. In the previous
patch you have removed the umounts but left the (now useless) waiting in 
place.

Instead, we just need to remove fixup_udev completely. The patch will 
follow.

>
> Probably the author want to write && instead of &.
> I don't think, that we need to check errors here,
> because the next script is independent from the previous one.
>
> Signed-off-by: Andrey Vagin <avagin at openvz.org>
> ---
>   etc/dists/scripts/prestart.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/etc/dists/scripts/prestart.sh b/etc/dists/scripts/prestart.sh
> index da76ca1..5ab7895 100755
> --- a/etc/dists/scripts/prestart.sh
> +++ b/etc/dists/scripts/prestart.sh
> @@ -62,7 +62,7 @@ fixup_loginuid()
>   [ "x$VZ_KERNEL" = "xyes" ] && exit 0
>   [ "x$USERNS" = "xno" ] && exit 0
>   
> -fixup_udev &
> +fixup_udev
>   fixup_loginuid
>   
>   exit 0




More information about the Devel mailing list