[Devel] [patch crash v3 0/2] namespace support for net command
Dave Anderson
anderson at redhat.com
Fri Dec 5 11:06:23 PST 2014
----- Original Message -----
> Dear Dave,
> could you please take a look at v3 version of my patch set
>
> v3:
> - show_net_devices_v3: VALID_MEMBER checks now nsproxy_net_ns
> instead of task_struct_nsproxy
>
> v2:
> - compilation was fixed
> - nsproxy_net_ns moved to end of existing offset_table
> - -n key behavior was changed, now it can work without pid/task argument:
> "net" without arguments shows information about init_net
> "net -n" -- gets net namespace reference from current task
> "net -n pid|taskp" -- from specified task
> - "net -n" example was added into help
> - show_net_devices_v3: rollback to using of init_net on kernels without nsproxy support
> - tested, seems works correctly on RHEL6-based OpenVZ kernel
>
>
> Vasily Averin (2):
> net -n option renamed to -N
> namespace support for net command
>
> defs.h | 1 +
> help.c | 14 +++++++++++---
> net.c | 58 ++++++++++++++++++++++++++++++++++++++++++----------------
> symbols.c | 2 ++
> 4 files changed, 56 insertions(+), 19 deletions(-)
Looks good. I reworked the help page clarify it a bit.
Queued for crash-7.1.0:
https://github.com/crash-utility/crash/commit/c64fc95e3e384576d544dd2b8b5ca126ad363165
Thanks,
Dave
More information about the Devel
mailing list