[Devel] [PATCH -mm 0/6] memcg/kmem: cleanup naming and callflows
Vladimir Davydov
vdavydov at parallels.com
Fri Apr 25 05:33:06 PDT 2014
Hi,
In reply to "[PATCH RFC -mm v2 3/3] memcg, slab: simplify
synchronization scheme" Johannes wrote:
> I like this patch, but the API names are confusing. Could we fix up
> that whole thing by any chance?
(see https://lkml.org/lkml/2014/4/18/317)
So this patch set is about cleaning up memcg/kmem naming.
While preparing it I found that some of the ugly-named functions
constituting interface between memcontrol.c and slab_common.c can be
neatly got rid of w/o complicating the code. Quite the contrary, w/o
them call-flows look much simpler, IMO. So the first four patches do not
rename anything actually - they just rework call-flows in kmem cache
creation/destruction and memcg_caches arrays relocations paths. Finally,
patches 5 and 6 clean up the naming.
Reviews are appreciated.
Thanks,
Vladimir Davydov (6):
memcg: get rid of memcg_create_cache_name
memcg: allocate memcg_caches array on first per memcg cache creation
memcg: cleanup memcg_caches arrays relocation path
memcg: get rid of memcg_{alloc,free}_cache_params
memcg: cleanup kmem cache creation/destruction functions naming
memcg: cleanup kmem_id-related naming
include/linux/memcontrol.h | 40 +----
include/linux/slab.h | 12 +-
mm/memcontrol.c | 420 ++++++++++++++++++++------------------------
mm/slab.c | 4 +-
mm/slab.h | 24 ++-
mm/slab_common.c | 127 ++++++++++----
mm/slub.c | 10 +-
7 files changed, 320 insertions(+), 317 deletions(-)
--
1.7.10.4
More information about the Devel
mailing list