[Devel] [PATCH v7 01/11] don't call cpuacct_charge in stop_task.c
Glauber Costa
glommer at openvz.org
Wed May 29 04:03:12 PDT 2013
Commit 8f618968 changed stop_task to do the same bookkeping as the
other classes. However, the call to cpuacct_charge() doesn't affect
the scheduler decisions at all, and doesn't need to be moved over.
Moreover, being a kthread, the migration thread won't belong to any
cgroup anyway, rendering this call quite useless.
Signed-off-by: Glauber Costa <glommer at openvz.org>
CC: Mike Galbraith <mgalbraith at suse.de>
CC: Peter Zijlstra <a.p.zijlstra at chello.nl>
CC: Thomas Gleixner <tglx at linutronix.de>
---
kernel/sched/stop_task.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sched/stop_task.c b/kernel/sched/stop_task.c
index e08fbee..4142d7e 100644
--- a/kernel/sched/stop_task.c
+++ b/kernel/sched/stop_task.c
@@ -68,7 +68,6 @@ static void put_prev_task_stop(struct rq *rq, struct task_struct *prev)
account_group_exec_runtime(curr, delta_exec);
curr->se.exec_start = rq_clock_task(rq);
- cpuacct_charge(curr, delta_exec);
}
static void task_tick_stop(struct rq *rq, struct task_struct *curr, int queued)
--
1.8.1.4
More information about the Devel
mailing list