[Devel] [RFC PATCH] kmod: add ability to swap root in usermode helper

Stanislav Kinsbursky skinsbursky at parallels.com
Tue May 21 23:00:17 PDT 2013


21.05.2013 20:29, Oleg Nesterov пишет:
> On 05/21, J. Bruce Fields wrote:
>>
>> On Tue, May 21, 2013 at 05:28:36PM +0200, Oleg Nesterov wrote:
>>>
>>> OK, so do not do this. Export the new helper.
>>
>> You mean, export umh_set_fs_root() in the above?
>>
>> That might be OK.
>
> Yes, or even call_usermodehelper_root().
>
> I didn't argue with the new helper that, yes, has the additional
> argument. Although personally I think it would be better to not
> add it into kmod.c (until it has more users), but I am not sure
> there is a better place somewhere in nfs code. Whatever is more
> convenient for you.
>
> To me this looks like call_usermodehelper_keys().
>
> Oleg.
>

Thanks, Oleg. Sounds reasonable.

-- 
Best regards,
Stanislav Kinsbursky



More information about the Devel mailing list