[Devel] [PATCH v4 3/7] Also pass cmd_p pointer to container open

Glauber Costa glommer at parallels.com
Fri May 17 13:33:37 PDT 2013


On 05/17/2013 05:35 AM, Kir Kolyshkin wrote:
> 
> This is kinda becoming over-engineered (and now I realized I should have
> said it earlier,
> when reviewing the patch that added the first param).
> 
> I understand well why you need local_uid and local_gid from config and
> cmdline
> in ct_open(), but maybe this non-zero checks can be done later in the
> code, so
> instead of using just h->can_join_userns you can call a function,
> something like

I only need cmd_p at one moment: When we create the container. I think
it is better than to leave can_join_userns with the vps_p test only,
then. We can test it manually during fs_create, because there is the
place in which we really need it.




More information about the Devel mailing list