[Devel] [CRIU] [PATCH 1/6] vzctl: split ct_env_create

[Andrew Vagin]

On Thu, May 16, 2013 at 08:47:19PM +0400, Andrey Wagin wrote:
> 2013/5/16 Glauber Costa <glommer at parallels.com>:
> > On 05/16/2013 04:14 PM, Andrey Vagin wrote:
> >> +     ret = ct_env_create_real(arg);
> >> +     if (ret < 0)
> >>               return VZ_RESOURCE_ERROR;
> >> -     }
> >
> > Isn't it better to just keep the return values intact in create_real,
> > and then return them as is if ret != 0 ?
> 
> It returns PID of the init process. VZ_RESOURCE_ERROR is positive too

ct_env_create_real can return a negative value in a error case and
it can be inverted in cr_env_create

	ret = ct_env_create_real(arg);
	if (ret < 0)
		return -ret;

> 
> >
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu