[Devel] [PATCH 3/3] hooks_ct: fix ub limits setting for upstream containers

Igor M Podlesny openvz at poige.ru
Mon May 13 01:19:34 PDT 2013


On 13 May 2013 16:16, Glauber Costa <glommer at parallels.com> wrote:
> On 05/13/2013 12:11 PM, Igor M Podlesny wrote:
>> On 13 May 2013 16:11, Glauber Costa <glommer at parallels.com> wrote:
>>> On 05/13/2013 12:08 PM, Igor M Podlesny wrote:
>>>> On 13 May 2013 15:50, Glauber Costa <glommer at parallels.com> wrote:
>>>> [...]
>>>>>>    Aren't macroses supposed to be UPPER CASE named?
[...]
> putting CC back
>
> The way I see it, there is absolutely nothing to fix here.
> As I explained above, I believe coding style exists for a reason, and
> call for consistency to help one derive things about unknown code easier.
>
> This is a local macro, only exist within the scope of this function, it
> is use-once-and-forget, and won't be available anywhere else in the code.
>
> In this particular case, the only difference between the existing and
> proposed version is that one is easier to type, and the other is harder.

   Whoa, I don't insist, it was a suggestion and as to me it's quite
logical to fix inconsistent code style along with other fixes which
changes the same lines anyway.

--



More information about the Devel mailing list