[Devel] [PATCH 00/10] bitbucket.org/poige/vzctl/commits/branch/p_nifty

Igor M Podlesny openvz at poige.ru
Tue May 7 10:36:37 PDT 2013


On 7 May 2013 20:21, Kir Kolyshkin <kir at openvz.org> wrote:
> On 05/06/2013 11:42 PM, Igor Podlesny wrote:
>>
>> https://bitbucket.org/poige/vzctl/commits/branch/p_nifty
>>
>> Igor Podlesny (10):

applied {
>>    get_date() gets shorter
>>    logger() gets shorter
>>    vzctl_init_ploop_log() gets shorter
}

>>    Dont-Repeat-Yourself: refer variable only once
>>    max_netmask(): switch fits better
>>    get_pagesize(): init var @ declaration and simplify

applied {
>>    In C func() is to be func(void) generally
>>    get_num_cpu(): got rid of hardcoded string length
>>    get_num_cpu(): Use PROCCPU macros for "/proc/cpuinfo"
}

>>    get_num_cpu(): refactored
>>
>
> Patches 1,2,3 and 7,8,9 applied, rest is commented.

   ok, I'll try to modify the rest of them as well.
>
> Igor,
>
> I suggest you to now try some real bugs, instead of just doing cosmetic
> fixes.
> List of opened vzctl bugs can be found on bugzilla.openvz,org.

   Thanks. Those patches are consequences of getting myself familiar
with the code.
No promises, though.

--



More information about the Devel mailing list