[Devel] [PATCH RFC] sched: move h_load calculation to task_h_load
Vladimir Davydov
vdavydov at parallels.com
Mon Jul 15 03:00:42 PDT 2013
On 07/15/2013 12:28 PM, Peter Zijlstra wrote:
> OK, fair enough. It does somewhat rely on us getting the single
> rq->clock update thing right, but that should be ok.
Frankly, I doubt that rq->clock is the right thing to use here, because
it can be updated very frequently under some conditions, so that
cfs_rq->h_load can get updated several times during the same balance
run. Perhaps, jiffies would suit better for that purpose. This would
work as h_load update throttler similar to how it works now (I mean
rq->h_load_throttle in update_h_load()).
If there is something else you don't like/have some thoughts on, please
share - I'll try to improve.
Thank you for your feedback.
> But yeah, when you have stupid many cgroups we quickly need less h_load
> instances than there are cgroups.
More information about the Devel
mailing list