[Devel] [PATCH cgroup/for-3.14] cgroup: fix fail path in cgroup_load_subsys()

Li Zefan lizefan at huawei.com
Thu Dec 12 19:20:50 PST 2013


On 2013/12/13 3:17, Vladimir Davydov wrote:
> Calling cgroup_unload_subsys() from cgroup_load_subsys() after
> online_css() failure will result in a NULL ptr dereference on attempt to
> offline_css(), because online_css() only assigns css to cgroup on
> success. Let's fix that by skipping calls to offline_css() and
> css_free() in cgroup_unload_subsys() if there is no css, and freeing css
> in cgroup_load_subsys() on online_css() failure.
> 
> Signed-off-by: Vladimir Davydov <vdavydov at parallels.com>

I don't have strong preference on which way to go.

Acked-by: Li Zefan <lizefan at huawei.com>




More information about the Devel mailing list