[Devel] Moved vzstat's stuff under /etc/vz/vzstats/

Kir Kolyshkin kir at openvz.org
Sun Apr 28 22:06:35 PDT 2013


On 04/28/2013 08:48 PM, Igor Podlesny wrote:
> -- So it doesn't float around anymore. Encapsulation is a good way
> to reduce entropy in general.
> ---
>   vzstats      |    6 +++---
>   vzstats.spec |    6 +++---
>   2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/vzstats b/vzstats
> index ddf7f04..d53a877 100755
> --- a/vzstats
> +++ b/vzstats
> @@ -1,9 +1,9 @@
>   #!/bin/sh
>   
> -test -f /etc/vz/vzstats-disable && exit 0
> +test -f /etc/vz/vzstats/disable && exit 0
>   
> -. /etc/vz/vzstats.conf
> -IDFILE=/etc/vz/.vzstats-uuid
> +. /etc/vz/vzstats/conf
> +IDFILE=/etc/vz/vzstats/uuid
>   VERSION=0.2.1
>   CURL='curl -sS --connect-timeout 3'
>   
> diff --git a/vzstats.spec b/vzstats.spec
> index ecd64ee..4b1fb5a 100644
> --- a/vzstats.spec
> +++ b/vzstats.spec
> @@ -25,12 +25,12 @@ make %{?_smp_mflags}
>   %install
>   make install install-cronjob DESTDIR=%{buildroot}
>   # Needed for %ghost in %files section below
> -touch %{buildroot}%{_sysconfdir}/vz/.vzstats-uuid
> +touch %{buildroot}%{_sysconfdir}/vz/vzstats/uuid
>   
>   %files
>   %{_sbindir}/vzstats
> -%config %{_sysconfdir}/vz/vzstats.conf
> -%ghost %config(missingok) %{_sysconfdir}/vz/.vzstats-uuid
> +%config %{_sysconfdir}/vz/vzstats/conf
> +%ghost %config(missingok) %{_sysconfdir}/vz/vzstats/uuid
>   %dir %{_libexecdir}/%{name}
>   %{_libexecdir}/%{name}/*
>   %{_sysconfdir}/cron.monthly/*

Currently we have about 60 users, and I don't see that you are covering 
their their upgrade
from the existing version. Once you start taking care about that, moving 
existing config files
around won't be seen as such a good idea.

Plus, I don't anticipate any more files for vzstats.



More information about the Devel mailing list