[Devel] Variable declaration with initialization is preferred

Kir Kolyshkin kir at openvz.org
Sun Apr 28 21:57:50 PDT 2013


On 04/28/2013 08:31 PM, Igor Podlesny wrote:
> ---
>   src/vzctl-actions.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/vzctl-actions.c b/src/vzctl-actions.c
> index 8201f9e..e0cd261 100644
> --- a/src/vzctl-actions.c
> +++ b/src/vzctl-actions.c
> @@ -1468,10 +1468,9 @@ int run_action(envid_t veid, act_t action, vps_param *g_p, vps_param *vps_p,
>   	vps_param *cmd_p, int argc, char **argv, int skiplock)
>   {
>   	vps_handler *h = NULL;
> -	int ret, lock_id = -1;
> +	int ret = 0, lock_id = -1;
>   	struct sigaction act;
>   
> -	ret = 0;
>   	if ((h = vz_open(veid)) == NULL) {
>   		/* Accept to run "set --save --force" on any kernel,
>   		 * otherwise error out if initialization failed

Applied, thanks.



More information about the Devel mailing list