[Devel] [fuse-devel] [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

[Miklos Szeredi]

On Thu, Apr 25, 2013 at 4:29 PM, Maxim V. Patlasov
<mpatlasov at parallels.com> wrote:
>> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
>> index 0713bfb..c47bcd4 100644
>> --- a/mm/page-writeback.c
>> +++ b/mm/page-writeback.c
>> @@ -1235,7 +1235,8 @@ static void balance_dirty_pages(struct address_space
>> *mapping,
>>                  */
>>                 nr_reclaimable = global_page_state(NR_FILE_DIRTY) +
>>
>> global_page_state(NR_UNSTABLE_NFS);
>> -               nr_dirty = nr_reclaimable +
>> global_page_state(NR_WRITEBACK);
>> +               nr_dirty = nr_reclaimable +
>> global_page_state(NR_WRITEBACK) +
>> +                       global_page_state(NR_WRITEBACK_TEMP);
>>                 global_dirty_limits(&background_thresh, &dirty_thresh);
>
>
> Please drop this patch. As we discussed in LSF/MM, the fix above is correct,
> but it's not enough: we also need to ensure disregard of NR_WRITEBACK_TEMP
> when balance_dirty_pages() is called from fuse daemon. I'll send a separate
> patch-set soon.

Please elaborate.  From a technical perspective "fuse daemon" is very
hard to define, so anything that relies on whether something came from
the fuse daemon or not is conceptually broken.

Thanks,
Miklos