[Devel] Re: [PATCH 2/6] fuse: categorize fuse_get_req()

[Miklos Szeredi]

Maxim Patlasov <mpatlasov at parallels.com> writes:

> The patch categorizes all fuse_get_req() invocations into three categories:
>  - fuse_get_req_nopages() - when caller doesn't care about req->pages
>  - fuse_get_req_onepage() - when caller need exactly one page
>  - fuse_get_req_multipage() - in other cases.

I think you are overcomplicating this.

Just have two functions: fuse_get_req_nopages() and fuse_get_req().

I don't think the _onepage variant deserves a separate helper.

Thanks,
Miklos