[Devel] Re: [PATCH v5 15/18] Aggregate memcg cache values in slabinfo

Christoph Lameter cl at linux.com
Fri Oct 19 12:50:37 PDT 2012


On Fri, 19 Oct 2012, Glauber Costa wrote:

> +
> +/*
> + * We use suffixes to the name in memcg because we can't have caches
> + * created in the system with the same name. But when we print them
> + * locally, better refer to them with the base name
> + */
> +static inline const char *cache_name(struct kmem_cache *s)
> +{
> +	if (!is_root_cache(s))
> +		return s->memcg_params->root_cache->name;
> +	return s->name;
> +}

Could we avoid this uglyness? You can ID a slab cache by combining a memcg
pointer and a slabname.




More information about the Devel mailing list