[Devel] Re: [RFC PATCH v2] posix timers: allocate timer id per task

Eric Dumazet eric.dumazet at gmail.com
Wed Oct 17 06:44:26 PDT 2012


On Wed, 2012-10-17 at 17:18 +0400, Stanislav Kinsbursky wrote:

> +static int hash(struct signal_struct *sig, unsigned int nr)
> +{
> +	int hash = hash_ptr(sig, POSIX_TIMERS_HASH_BITS);
> +	return hash ^ hash_32(nr, POSIX_TIMERS_HASH_BITS);
> +}
> +

This is quite expensive on 64 bit arches. I suggest instead :

return hash_32(hash32_ptr(sig) ^ nr, POSIX_TIMERS_HASH_BITS);





More information about the Devel mailing list