[Devel] Re: [PATCH v4 06/14] memcg: kmem controller infrastructure

Michal Hocko mhocko at suse.cz
Thu Oct 11 05:56:03 PDT 2012


On Thu 11-10-12 14:42:12, Michal Hocko wrote:
[...]
> 	/*
> 	 * Keep reference on memcg while the page is charged to prevent
> 	 * group from vanishing because allocation can outlive their
> 	 * tasks. The reference is dropped in __memcg_kmem_uncharge_page
> 	 */
> 
> please
> > +	mem_cgroup_get(memcg);

Ahh, this will go away. The it doesn't make much sense to add the
comment here.
-- 
Michal Hocko
SUSE Labs




More information about the Devel mailing list