[Devel] Re: [PATCH] slub: don't create a copy of the name string in kmem_cache_create

Christoph Lameter cl at linux.com
Mon Apr 16 07:02:07 PDT 2012


On Fri, 13 Apr 2012, Glauber Costa wrote:

> When creating a cache, slub keeps a copy of the cache name through
> strdup. The slab however, doesn't do that. This means that everyone
> registering caches have to keep a copy themselves anyway, since code
> needs to work on all allocators.
>
> Having slab create a copy of it as well may very well be the right
> thing to do: but at this point, the callers are already there

What would break if we would add that to slab? I think this is more robust
because right now slab relies on the caller not freeing the string.




More information about the Devel mailing list